search

NixOS / ofborg

@ofborg tooling automation https://monitoring.ofborg.org/dashboard/db/ofborg
https://ofborg.org
MIT License
230 stars 164 forks source link

Please include haskellPackages and rPackages in build checks #155

Open peti opened 6 years ago

peti commented 6 years ago

Could you please configure the copy of Nixpkgs used for the evaluation and build checks to include haskellPackages and rPackages? https://github.com/NixOS/nixos-homepage/pull/201 has a simple override that can be applied to achieve this by adding the (normally absent) recurseIntoAttrs modifier to those attribute sets.

grahamc commented 6 years ago

Hey Peter, I think we already do: https://github.com/NixOS/ofborg/blob/released/ofborg/src/outpaths.nix or is there a specific example of where it did the wrong thing?

Thank you, Graham

On Sun, Apr 8, 2018, 2:53 AM Peter Simons notifications@github.com wrote:

Could you please configure the copy of Nixpkgs used for the evaluation and build checks to include haskellPackages and rPackages? NixOS/nixos-homepage#201 https://github.com/NixOS/nixos-homepage/pull/201 has a simple override that can be applied to achieve this by adding the (normally absent) recurseIntoAttrs modifier to those attribute sets.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/NixOS/ofborg/issues/155, or mute the thread https://github.com/notifications/unsubscribe-auth/AAErrNU5BAnT7T5H1Qcb9fyAho5sd_xOks5tmbP0gaJpZM4TLaoa .

peti commented 6 years ago

Hmm, I see that haskellPackages is checked already, but rPackages is not.

LnL7 commented 6 years ago

The release.nix includes recurseIntoAttrs for the haskell set so hydra builds them, it looks like this was disabled for rPackages.

peti commented 6 years ago

ping?

grahamc commented 5 years ago

I would like ofBorg to verify rPackages too. With it disabled here: https://github.com/NixOS/nixpkgs/blob/99f4e548c49e3dfc3d1c7f4996c1d72da2623f00/pkgs/top-level/release.nix#L174 is there an easy way to edit https://github.com/NixOS/ofborg/blob/released/ofborg/src/outpaths.nix to also expand rPackages without specifically mentioning rPackages?