search

NixOS / ofborg

@ofborg tooling automation https://monitoring.ofborg.org/dashboard/db/ofborg
https://ofborg.org
MIT License
235 stars 166 forks source link

ofBorg repeatedly requests reviews in one thread #317

Open Ma27 opened 5 years ago

Ma27 commented 5 years ago

An example for this behavior is the following thread: https://github.com/NixOS/nixpkgs/pull/55101

The initial change was a Hydra bump and I my review got requested as I'm a Hydra package maintainer ATM. After my approval I pushed an improved version of the NixOS Hydra test to the branch which tests Hydra with multiple Nix versions. Then, my review got requested again (as I'm a maintainer of the NixOS test as well).

I guess this a bug as I'm listed as reviewer twice in the info box with the merge button at the bottom of the thread and the original review status in the "Reviewers" box on the right has changed from "approved" to "pending".

I'd be happy to send a fix, but first I'd like to know if this is expected behavior or an actual bug :)

sersorrel commented 12 months ago

This issue persists (e.g. https://github.com/NixOS/nixpkgs/pull/258794); it would be nice if ofborg would not request review from someone who has already approved the most recent commit.

Thra11 commented 8 months ago

I saw this again today: https://github.com/NixOS/nixpkgs/pull/279330

Once I've approved something, I expect it to stay approved as long as the commits haven't changed, so this definitely looks like a bug to me.

sersorrel commented 6 months ago

It seems like hubcaps might not currently support the API endpoints which tell you who's already reviewed a PR: https://github.com/softprops/hubcaps/issues/143

...hubcaps has not seen a commit in nearly two years, so that "currently" might be overstating things...