search

NixOS / ofborg

@ofborg tooling automation https://monitoring.ofborg.org/dashboard/db/ofborg
https://ofborg.org
MIT License
244 stars 164 forks source link

Create a tag for simple PRs #401

Open Anton-Latukha opened 5 years ago

Anton-Latukha commented 5 years ago

Would be great if bot marked as simple trivial in logic update/(info update) PRs.

If PR changes only version, maintainers, description, long description, fields, & maybe also license.

Currently the trivial updates are indistinguishable from the complex epic PRs, which means maintainer does not see which PRs are easier.

But there exists a big flow of trivial PRs.

And this tagging would allow maintainers to have better concentration and automation & have a possibility to go into casu'el burst bulk review&merge of a lot of simple PRs. This can also allow further automation of the review process & merging of simple updates.

FRidh commented 5 years ago

First, Nixpkgs would need to adopt such a tag. We actually have one already that could be used 3.skill: trivial.

davidak commented 5 years ago

@FRidh there is a difference between tasks that require trivial skill (but could take long to complete) and tasks that are simple (and therefore fast to complete but might require expert skill).

When you look at what PRs actually tagged with that label, there are many bigger tasks like new packages or changes to over 100 files.

https://github.com/NixOS/nixpkgs/pulls?q=is%3Apr+label%3A%223.skill%3A+trivial%22+is%3Aclosed

https://github.com/NixOS/nixpkgs/pull/28031 https://github.com/NixOS/nixpkgs/pull/8047

I think an additional label for simple to review PRs is a good idea!