search

NixOS / ofborg

@ofborg tooling automation https://monitoring.ofborg.org/dashboard/db/ofborg
https://ofborg.org
MIT License
243 stars 164 forks source link

tasks/eval/nixpkgs: don't re-request reviews #593

Closed ncfavier closed 2 years ago

ncfavier commented 2 years ago

Don't request a new review from a maintainer who has already reviewed a PR.

cole-h commented 2 years ago

Is there any particular reason why you don't want a new review requested after changes have been made?

ncfavier commented 2 years ago

Reviewers are subscribed to the PR so they were already notified of the changes. I think it should be up to the PR author to decide whom and when to rerequest a review from.

But the motivating case that just happened to me is: maintainer adds a review before ofborg finishes eval, then ofborg wakes up and requests a review from them again.

SuperSandro2000 commented 2 years ago

With that feature you can easily filter notifications for more important ones https://github.com/notifications?query=reason%3Areview-requested

If I am tight on time I am not reacting to the 100+ nixpkgs notifications I get per day but the review rerequest shows me that someone pushed to the PR and most of the time has fixed my remarks.

ncfavier commented 2 years ago

Ok, that's fair. Maybe we can skip rerequests only on the first ofborg eval, then.

SuperSandro2000 commented 2 years ago

I don't know how easy that is to do and it sounds like quite a complication for such a small thing in my opinion.

ncfavier commented 2 years ago

Oh well.