search

NixOS / ofborg

@ofborg tooling automation https://monitoring.ofborg.org/dashboard/db/ofborg
https://ofborg.org
MIT License
244 stars 166 forks source link

Eval tests should be executed with the lowest supported Nix version (2.3) #612

Open sternenseemann opened 2 years ago

sternenseemann commented 2 years ago

I ran into the first instance of path interpolation syntax slipping into nixpkgs today: https://github.com/NixOS/nixpkgs/pull/188466. Our lib/minver.nix prescribes that we support everything from 2.3 upwards.

Without CI to catch it, it is quite understandable that contributors accidentally introduce such changes (who remembers the changelog precisely?). Running the eval checks on the oldest supported Nix version should be enough, as any accepted Nix expressions under 2.3 should be forwards compatible.

ghost commented 1 year ago

I made this mistake too: https://github.com/NixOS/nixpkgs/pull/210207

OfBorg really needs to check this.

SuperSandro2000 commented 1 year ago

This would also remove all performance optimizations done since the minimum supported versions.

infinisil commented 1 year ago

This is now implemented in Nixpkgs directly: https://github.com/NixOS/nixpkgs/commit/013acf2396f451c73b6cd6b0148df21cbaa4c165

ShamrockLee commented 10 months ago

Here is the explanation by @infinisil about the minimum supported Nix version on NixOS Discourse:

https://discourse.nixos.org/t/when-is-a-nix-builtin-function-builtins-considered-ready-to-be-used-inside-nixpkgs/35369/2