search

NixOS / ofborg

@ofborg tooling automation https://monitoring.ofborg.org/dashboard/db/ofborg
https://ofborg.org
MIT License
232 stars 166 forks source link

nix: build unfree packages #644

Closed rhendric closed 1 year ago

rhendric commented 1 year ago

Closes #194.

Example PR where this would have been helpful: https://github.com/NixOS/nixpkgs/pull/236695

SuperSandro2000 commented 1 year ago

unfree packages are for a reason unfree and most likely fail to build because ofborg cannot obtain the source or we are not allowed to build the packages.

rhendric commented 1 year ago

Wish that had been feedback left on #194. It's hard to pick off small contributions to make when issues are met with silence and only after one does the work do the thumbs-down come out. I mean, unless you don't like growing the set of contributors, in which case great job, keep it up.

On this issue, though: if the source isn't available, the build fails almost immediately. Why is that worse than failing immediately regardless of whether the source is available? Hydra builds non-free packages (I think? I assume that's where they come from when I install them and they aren't built locally); why would ofborg not be allowed to?

SuperSandro2000 commented 1 year ago

Hydra builds non-free packages

No it doesn't because most of the time the restrictive and unfree licenses do not allow that. If hydra would build them ofcourse ofborg could, too.

JulienMalka commented 1 year ago

I don't see how unfree packages could not be buildable at all and still distributed through nixpkgs.

SuperSandro2000 commented 1 year ago

We are not distributing them, we are distributing code to be able to build them if you confirming to their licenses.

JulienMalka commented 1 year ago

I know this, it doesn't mean we could not have ofborg build them without distributing the results, that is I believe the proposition here. I don't have any strong feeling about it, but I feel like if we are to discard this proposition, let us discard it with legit points.

SomeoneSerge commented 2 months ago

unfree packages are for a reason unfree and most likely fail to build because ofborg cannot obtain the source or we are not allowed to build the packages.

Isn't it exceedingly rare that we are not allowed to build the derivations? Redistribution is usually the point of contention, never evaluation, and (I believe) rarely the "building". We can literally count these things by checking how many attributes with !meta.license.free there are, and how many derivations rely on requireFile