Open trofi opened 8 months ago
https://github.com/NixOS/nixpkgs/pull/276892 is another case where just following commit message attribute might be more desirable.
It's a no-op change from rebuild standpoint but I still would prefer maintainers to review that kind of change.
Example PR: https://github.com/NixOS/nixpkgs/pull/276696
There:
nix_2_3
(ornixVersions.nix_2_3
) was explicitly specified in commit message.nix repl
agrees$attr.meta.maintainers
does exist:nix-repl> nixVersions.nix_2_3.meta.maintainers
=>[ { ... } { ... } ]
nixVersions.nix_2_3
rebuild@lilyinstarlight says it's a side-effect of
nixVersions.nix_2_3
defining most of it's relevant attributes in a file different fromdefault.nix
(common.nix
). I suspectnix
is not the only one doing it.Proposal: extend
ofborg
to also handle direct$attr.meta.maintainers
expand attributes right from the commit message (and possibly filter only on packages affected by the rebuild if reasonably feasible). I suspect that is what it does today to fetch tests and build the attribute.