search

NixOS / patchelf

A small utility to modify the dynamic linker and RPATH of ELF executables
GNU General Public License v3.0
3.57k stars 487 forks source link

Fix wrong completion #495

Open Freed-Wu opened 1 year ago

Freed-Wu commented 1 year ago

Sorry for a typo. According to https://zsh.sourceforge.io/Doc/Release/Completion-System.html#Completion-Functions's _arguments, --long-option[description of option]:name of argument:completion method should have 2 :s, not 3. Anyone can use patchelf --set-interpreter <TAB> to trigger this bug. And patchelf --print-* should be followed by a elf name: print some information about this elf then exit. So it shouldn't complete any other option (-), but should complete elf name (not (- : *), (*) will stop complete elf name).

Freed-Wu commented 9 months ago

@edolstra @Mic92 @domenkozar @brenoguim Any problem?

Mic92 commented 9 months ago

No just lack of time. Things will get better next month.