Open JQGoh opened 4 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Hey @JQGoh, thanks a lot for trying this approach! Although I think it's fine to add more arguments for now, we can give this a shot when we work towards v2.0.
Hey @JQGoh, thanks a lot for trying this approach! Although I think it's fine to add more arguments for now, we can give this a shot when we work towards v2.0.
In that case, I shall put this on hold then.
Rationale
set_configure_optimizers
function for the BaseModel class such that individual model can overwrite the default configure_optimizers() behaviorThis shall deprecate the earlier work introduced in: https://github.com/Nixtla/neuralforecast/pull/998