Nixtla / neuralforecast

Scalable and user friendly neural :brain: forecasting algorithms.
https://nixtlaverse.nixtla.io/neuralforecast
Apache License 2.0
2.75k stars 316 forks source link

[Core] Check input for NaNs #890

Closed jmoralez closed 4 months ago

jmoralez commented 5 months ago

Description

If any of the inputs contains NaNs with available_mask = 1 they will be used for training and can be propagated to the predictions or produce failures in training. We should check that the target, exogenous and static features don't have any NaNs for the rows where available_mask = 1 and provide an informative error message if they do.

Use case

This will help saving time when trying to train models on invalid inputs, since it will fail before starting the training process.

cchallu commented 5 months ago

@quest-bot stash 100

quest-bot[bot] commented 5 months ago

New Quest! image New Quest!

A new Quest has been launched in @Nixtla’s repo. Merge a PR that solves this issue to loot the Quest and earn your reward.


Loot of 100 USD has been stashed in this issue to reward the solver!

🗡 Comment @quest-bot embark to check-in for this Quest and start solving the issue. Other solvers will be notified!

⚔️ When you submit a PR, comment @quest-bot loot #890 to link your PR to this Quest.

Questions? Check out the docs.

JQGoh commented 5 months ago

@quest-bot embark

quest-bot[bot] commented 5 months ago

@JQGoh has embarked on their Quest. 🗡

Questions? Check out the docs.

quest-bot[bot] commented 4 months ago

🧚 @JQGoh has submitted PR https://github.com/Nixtla/neuralforecast/issues/894 and is claiming the loot.

Keep up the pace, or you'll be left in the shadows.

Questions? Check out the docs.

jmoralez commented 4 months ago

Fixed by #894

cchallu commented 4 months ago

@quest-bot reward @JQGoh

quest-bot[bot] commented 4 months ago

Quest solved! image Quest solved!

Congratulations! Your efforts have paid off. A PR that solves this Quest has been merged.


@JQGoh, you have been victorious in Quest #890 🗡

💰 To claim your $100 reward follow instructions here

🧚 Thanks to all bold adventurers for attempting this quest! Sign-up to Quine.sh to access more exciting Quests like this one ⚔️

This Quest is now closed ✨

Questions? Check out the docs.