Closed ggattoni closed 4 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
thank you so much @ggattoni! could you sign the CLA? thank you!🙌
thank you so much @ggattoni! could you sign the CLA? thank you!🙌
Sure, it's done! Let me know if I can do anything else
Hi @ggattoni! Thanks for your contribution. The nb-sync test failed, I believe you missed installing the hooks with nbdev. Can you try running nbdev_install_hooks
, modifying the new linear notebook, and pushing it again? (contributing guide: https://github.com/Nixtla/neuralforecast/blob/main/CONTRIBUTING.md)
Hi @ggattoni! Thanks for your contribution. The nb-sync test failed, I believe you missed installing the hooks with nbdev. Can you try running
nbdev_install_hooks
, modifying the new linear notebook, and pushing it again? (contributing guide: https://github.com/Nixtla/neuralforecast/blob/main/CONTRIBUTING.md)
Whoops, I thought I had configured it correctly, now it should be fixed
Since DLinear was added recently, I think it might be a good idea to also have NLinear in the library. If you are interested and/or if I'm missing something please let me know