Nixtla / neuralforecast

Scalable and user friendly neural :brain: forecasting algorithms.
https://nixtlaverse.nixtla.io/neuralforecast
Apache License 2.0
2.75k stars 316 forks source link

[FEAT] Added NLinear model #900

Closed ggattoni closed 4 months ago

ggattoni commented 4 months ago

Since DLinear was added recently, I think it might be a good idea to also have NLinear in the library. If you are interested and/or if I'm missing something please let me know

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

CLAassistant commented 4 months ago

CLA assistant check
All committers have signed the CLA.

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ggattoni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

AzulGarza commented 4 months ago

thank you so much @ggattoni! could you sign the CLA? thank you!🙌

ggattoni commented 4 months ago

thank you so much @ggattoni! could you sign the CLA? thank you!🙌

Sure, it's done! Let me know if I can do anything else

cchallu commented 4 months ago

Hi @ggattoni! Thanks for your contribution. The nb-sync test failed, I believe you missed installing the hooks with nbdev. Can you try running nbdev_install_hooks, modifying the new linear notebook, and pushing it again? (contributing guide: https://github.com/Nixtla/neuralforecast/blob/main/CONTRIBUTING.md)

ggattoni commented 4 months ago

Hi @ggattoni! Thanks for your contribution. The nb-sync test failed, I believe you missed installing the hooks with nbdev. Can you try running nbdev_install_hooks, modifying the new linear notebook, and pushing it again? (contributing guide: https://github.com/Nixtla/neuralforecast/blob/main/CONTRIBUTING.md)

Whoops, I thought I had configured it correctly, now it should be fixed