Nixtla / neuralforecast

Scalable and user friendly neural :brain: forecasting algorithms.
https://nixtlaverse.nixtla.io/neuralforecast
Apache License 2.0
2.7k stars 312 forks source link

add check for cells with imports and code #954

Closed jmoralez closed 3 months ago

jmoralez commented 3 months ago

When building the docs nbdev runs all cells containing import statements, so it's in our best interest to isolate the imports in separate cells so that other code like tests isn't run when building the docs. This adds a check to pre-commit that will fail if there are such cells and will print the notebook path which contains them.

These are mostly changes to the notebooks, however in two modules we were running the following:

logging.getLogger("pytorch_lightning").setLevel(logging.ERROR)
warnings.filterwarnings("ignore")

which I'm guessing was unintended and so this deletes that.

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB