NiyaShy / XB1ControllerBatteryIndicator

A tray application that shows a battery indicator for an Xbox-ish controller and gives a notification when the battery level drops to (almost) empty.
GNU General Public License v2.0
715 stars 51 forks source link

App Localization #18

Closed Friday-The13-rus closed 5 years ago

Friday-The13-rus commented 5 years ago

3

Hi! I would like to suggest a way to translate the app to different languages.

Friday-The13-rus commented 5 years ago

New translation can be added using following steps: 1) Add new resource file into Localization folder with suffix from here изображение

2) Copy all existing strings from Strings.resx file to the new file 3) Translate a text in 'Value' column

Language of the application will be selected automatically based on windows language.

As an example I translated the app to Russian.

Friday-The13-rus commented 5 years ago

Translation can be delegated to different person. He or she have to download the file XB1ControllerBatteryIndicator/XB1ControllerBatteryIndicator/Localization/Strings.resx and translate all values in data elements изображение And then somehow provide translated file to @NiyaShy

NiyaShy commented 5 years ago

Hey, thanks for the pull request, this looks very promising. There's just one thing that bugs me: automatic selection of the language based on your system language. While it's nice to have, there might be others like me who prefer to run certain programs in a language that differs from their system (in my case, German system, but I run quite a few programs in English). Ideally, it would be nice if it would pick the language based on your system by default, but you are still able to change it yourself via the context menu.

Friday-The13-rus commented 5 years ago

Thanks. I'll try to add this improvement.

Friday-The13-rus commented 5 years ago

Hi. Now the language can be changed manually. The selected language is saved in the settings. изображение

NiyaShy commented 5 years ago

Perfect, works like a charm. Thanks a lot for your work!