search

NiyaShy / XB1ControllerBatteryIndicator

A tray application that shows a battery indicator for an Xbox-ish controller and gives a notification when the battery level drops to (almost) empty.
GNU General Public License v2.0
715 stars 51 forks source link

Internationalization #3

Open dodekaphilist opened 6 years ago

dodekaphilist commented 6 years ago

I'd like to translate the programm into my language for a better integration into the system. Could you provide support for that?

NiyaShy commented 6 years ago

Uh, well... It probably could be done, but in the current state all messages are inside the code. So it would require some re-writing and i'd have to dig into how to include external files (think that would be the easiest way to include new languages).

Friday-The13-rus commented 5 years ago

@NiyaShy could you please look at the pull request and, if all is OK from your point of view, merge it into your repository?

NiyaShy commented 5 years ago

Thanks to the code @RogerUP13 provided there is now a working translation/language switcher system in the code which will be released with version 1.3.0.0. Wanna help with a new translation? Download the English string file (right click -> save target), open it in Notepad (or your favourite text editor) and edit the strings in the \<data> elements that start at line 120. Save the file as Strings.\<language code>.resx (you can find the 2-letter ISO 649-1 codes here). So the file for German would be called Strings.de.resx. When you're done, upload the file somewhere and let me know about it here or over on reddit. If you know how to use Git(hub) you can of course also create a pull request.

Currently we have translations for English (d'uh), German, Spanish and Russian. Once 1.3 is released I'll keep updated lists of the added languages here (haven't decided yet if I'll keep them in the main description or the wiki page) and over on the pinned thread on Reddit. EDIT: as of 1.3.0, I'll keep an up to date list of the included languages in the description of the current release.

If new languages get added after the release of 1.3, I'll (probably) NOT increment the version number of the program and just update the released program file, so there will be no "new version" notifications for that. If your language hasn't been added yet, just check back every once in a while to see if it was added.

buzzcola107 commented 5 years ago

Hi, I translate in French (fr).

Strings_fr.zip

And I have a feedback/suggestions: The other day I was playing GTAV and the warning (toast) appeared in mission over the map ( and I fail the mission lol ). And if i click on the button Shut up!, its minimizes the game (risk of crash in some game).

I ask if it is possible to just make the warning appear only for a few seconds ( like 7 seconds )

(sorry for my bad English )

I really like your software, good day and good luck !

NiyaShy commented 5 years ago

Hey,

thanks for the French translation. I'll try to add it soon-ish.

And about your other feedback, i'll split that off into a separate issue to stay on topic here.

DrUm78 commented 5 years ago

buzzcola107 > Sorry to say that but your French translation has a few mistakes (I'm French as well). I'm gonna explain a few of those in French:

NiyaShy > Here is my version, which is better (please no offense in that), but can be improved for sure if needed: Strings_fr.zip

rybomir commented 5 years ago

Hi, added Polish translation.

Strings.pl.zip

Cheers.

NiyaShy commented 5 years ago

Hey, @Drumaster78 I can't really judge if your version is better than the version buzzcola107 made since my French is very basic, so I'll have to take your word for it. Added it. @rybomir thanks, I'll add it in the next days.

AlisaAkiron commented 5 years ago

Hi, I translate in Chinese (zh).

Strings.zh.zip

NiyaShy commented 5 years ago

Thanks, I will add it when I find the time. But please do not spam, I got 4 notifications that you posted about your translation, one of them in an unrelated issue...

AlisaAkiron commented 5 years ago

I am sorry about that. I will pay attention to that in the future. :)

KT-Yeh commented 5 years ago

Hi, I added Traditional Chinese.

Strings.zh-tw.zip

The file name I used is zh-tw because this is to distinguish between zh-cn for Simplified Chinese and zh-tw for Traditional Chinese.

NiyaShy commented 5 years ago

Hey, thanks for the translation. Just tried adding both yours and the simplified version and it seems to work fine when the resx files have the "extended" codes (zh-cn and zh-tw). Will upload the updated version soon-ish, probably today.

iury commented 5 years ago

Hello,

I've translated to Brazilian Portuguese.

Strings.pt-br.zip

Cheers

Friday-The13-rus commented 5 years ago

Hey, thanks for the translation. Just tried adding both yours and the simplified version and it seems to work fine when the resx files have the "extended" codes (zh-cn and zh-tw). Will upload the updated version soon-ish, probably today.

Sure, all "extended" or region-specific language codes are also supported.

Fridolin2269 commented 5 years ago

Thanks for the nice app. Here is the translation to Danish. Strings.da.zip

NiyaShy commented 5 years ago

@iury sorry, somehow I missed (or forgot) about your translation. Will add it soon-ish. @Fridolin2269 thanks, but it seems your file has some encoding issues. Visual Studio complains about invalid characters and Notepad++ shows characters that apparently aren't a part of the UTF-8 charset. See here. Please fix those.

Fridolin2269 commented 5 years ago

@NiyaShy @Fridolin2269 . Here is another translation without danish and norwegian special characters. Hope it works this time. Strings.da.zip

NiyaShy commented 5 years ago

@Fridolin2269 sorry, but there are still unknown characters in it, on line 139, 154 and 157. Don't know much about Danish, but aren't the special characters part of unicode/UTF-8? Would be kinda weird considering that even all the asian languages and their special characters are included.

I just tried to look it up, and apparently characters like ø or æ are a part of UTF-8. What kind of characters were you trying to use? And what program did you use to edit the file? If you can, please try it with a text editor like Notepad++ and set it to UTF-8 encoding (without BOM). That way you should be able to see right away if a character you typed was encoded wrong.

Fridolin2269 commented 5 years ago

@NiyaShy have now made the change in notepad++ with UTF-8 encoding (without BOM), so hopefully it works this time. Sorry for the inconvenience. Strings.da.zip

NiyaShy commented 5 years ago

Looking good this time, no weird characters and so far VS hasn't complained.

And no problem, with that hot mess of different encoding types that exist around the world it can always happen that small issues occur. Thanks for the translation, will upload it soon-ish.

gongwonchong commented 5 years ago

i translated korean. i hopefully works fine. Strings.kr.zip

NiyaShy commented 5 years ago

Hey, thanks for the translation. No issues with it, but the language code was wrong (kr is Kanuri, Korean is ko).
Just uploaded the new version that includes it~

djmdesign commented 4 years ago

I didn't know unopened a case.. anyways I was thanking you

zeular commented 3 years ago

Hi, I have translated to swedish! Strings.sv.resx.zip

NiyaShy commented 1 year ago

Ugh, sorry @zeular but I somehow managed to completely forget about your translation... It's now added to the code repo and I'll upload an updated exe file soon-ish.

songmin9813 commented 1 year ago

I translated it into Japanese based on Korean. Strings.jp.zip

NiyaShy commented 1 year ago

Thanks, I'll implement it in the next few days. Just as a side note, the language/ISO code was wrong, the code for Japanese isn't "jp" but "ja" ;)