search

NiyaShy / XB1ControllerBatteryIndicator

A tray application that shows a battery indicator for an Xbox-ish controller and gives a notification when the battery level drops to (almost) empty.
GNU General Public License v2.0
722 stars 52 forks source link

Update Strings.tr.resx #68

Closed BurakCD closed 1 year ago

BurakCD commented 2 years ago

Some improvements for Turkish Language. I'm Ethadien from Reddit :)

NiyaShy commented 1 year ago

Hey, thanks for the PR. While I can't understand Turkish at all I still noticed a change you made that seems a bit odd to me: Doubling up on the word "battery" for the status levels.

The English (and pretty much all other) translation(s) has/have only the state/level in the variables BatteryLevel_Empty, BatteryLevel_Full etc. That way the tooltip looks roughly like: Controller 1 - Battery level: Medium

Your change makes the Turkish tooltip look like this: Kontrolcü 1 batarya yüzdesi: Batarya yarı dolu

See what I mean?

BurakCD commented 1 year ago

There are such usages in Turkish. I'll change it and send it again.

NiyaShy commented 1 year ago

If that's a "quirk" of the Turkish language it's totally fine and you don't have to change it back. Was just wondering if it was intentional :)