search

NiyaShy / XB1ControllerBatteryIndicator

A tray application that shows a battery indicator for an Xbox-ish controller and gives a notification when the battery level drops to (almost) empty.
GNU General Public License v2.0
710 stars 53 forks source link

Changing target .NET framework to 4.8 (and updating some packages) breaks language selection #92

Closed NiyaShy closed 1 month ago

NiyaShy commented 1 month ago

Since Visual Studio 2022 was complaining about the project still running on an older .NET framework (IIRC 2.5.X) I tried changing it to .NET 4.8. After a lot of trial and error with updating packages and making smaller adjustments to code that VS complained about, the program runs (again), but one big problem appeared: it defaults to your system language and picking any other language from the context menu does nothing aside from moving the check mark in the menu.

I already tried to find out why it happens, but neither VS nor the program itself give me any hints about what's wrong. The only warning/error i still get in VS is that Caliburn Micro 3.2.0.0 is allegedly not available/installed (which is not the case), that most likely comes from the package version switcharoo I did. Can't say if it has anything to do with the language switcher.

@Friday-The13-rus could you take a look at it? Since you programmed the language switch implementation I hope you might have better luck finding the issue. I've uploaded the changed code from my trials into a separate branch called dotnet4.8.

Friday-The13-rus commented 1 month ago

@NiyaShy Hi. I'll take a look in a few days. This shouldn't be a big issue.

NiyaShy commented 1 month ago

Thanks for the fast fix, just merged your PR and language switching works again.