NizarMohd / pe

0 stars 0 forks source link

lifeline in SD #7

Open NizarMohd opened 4 years ago

NizarMohd commented 4 years ago

image.png

I am not entirely sure of the reason but you way want to look into this.

Constructor doesn not have its life line continued, probably because of the arrows crossing the lifeline. However you can consider overlapping the return arrows over the lifeline until its intended destruction. Or amybe if it is unused afterwards, you can consider destroying it.

This seems to be the acse for toher SDs too.

nus-pe-bot commented 4 years ago

Team's Response

Yes, an 'X' could perhaps been drawn to illustrate the destruction of the Parser object. However, I am not entirely sure whether it is compulsory to do so since in Java, the object is not explicitly destroyed, but rather implicitly by the "Garbage collector".

However, I am still willing to accept this as a bug, although I have lowered the severity, since the general idea of the sequence diagram can be understood, and only results in minor inconvenience.

Thank you for spotting this error and raising this issue to us.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your reason]