search

Nj0be / HandBrake-SVT-AV1-PSY

41 stars 2 forks source link

Update runners, formatting, and lto #6

Closed Uranite closed 1 month ago

Uranite commented 1 month ago

ubuntu-latest is using Ubuntu 22.04 instead of Ubuntu 24.04 for some reason Enabled LTO for macOS, Ubuntu, and Arch Linux LTO doesn't work with Clang, so we're using GCC (except on Mac it just works for some reason) Arch Linux was never even using Clang in the first place because it wasn't explicitly set I couldn't get LTO to work for Windows and Flatpak For Windows, I tried using GCC 14.2.0, and it fails for some reason (ignore arm I don't think there is a GCC toolchain for it) Flatpak just seems to ignore --lto=on I also tried to make Flatpak use Clang, but it just won't use Clang for some reason

Nj0be commented 1 month ago

Good job, I also like the refactoring you did. I tried it quickly on arch linux and it seems to work. Of course, if there is anyone who wants to try out the new builds, it would always be helpful. Thank you very much for the improvements you made with the two pull request.