Njanderson / resmon

Displays resource utilization in the VSCode status bar.
80 stars 22 forks source link

setting has invalid type, expected string[] #32

Open necmettin opened 4 years ago

necmettin commented 4 years ago

I am a Mac user.

In VSCode settings ui, Resmon>Disk: Drives setting reports Setting has an invalid type, expected "String[]". Fix in JSON.

When you try to edit "resmon.disk.drives" in user settings json, these values do not work:

README notes "C:" for Windows and '/dev/sda1' for Linux. No examples for Mac. Single quotes are not accepted in settings JSON at all.

Although I don't want to see disk space in the status bar, what is the correct value to enter for resmon.disk.drives ?

bersbersbers commented 3 years ago

This has been fixed in 63cc9d7a05148b5aef495234356914512ddec6c7, but it seem that did not make it into the store version. The previous version had an incorrect type in package.json: https://github.com/Njanderson/resmon/blob/e3cf4730554a7cc4e8bd848c837b70d1bd4b598d/package.json#L66-L69

I tried modifying package.json along the lines of 63cc9d7a05148b5aef495234356914512ddec6c7, which fixed the JSON error but did not enable the functionality.

By the way, I think the expected notation is

"resmon.disk.drives": [
        "/home/bers",
        "/data/bers",
    ],