Nkaleth / Capstone2_art

This JavaScript capstone project is about building a web application based on an external API. We selected an API from a Museum that provides data about paintings and then we build the webapp around it. This webapp will have 3 user interfaces.
https://nkaleth.github.io/Capstone2_art/
1 stars 1 forks source link

Capstone block2 #21

Open Nkaleth opened 1 year ago

Nkaleth commented 1 year ago

https://github.com/Nkaleth/Capstone2_arts

We are 3 partners.

huseyinbiyik commented 1 year ago

Hi @Nkaleth,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Alt Text

Invalid Code Review Request

You have submitted a project, that has no link to the project. Kindly add the project link as requested on the project requirements.

Screenshot 2023-02-06 at 11 41 51 PM

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

Gambit142 commented 1 year ago

Hi @huseyinbiyik 👋,

Good job so far!

Highlights

There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Please make the following changes to your kanban board:

image

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, remember to tag me in your question so I can receive the notification. You can tag me by typing @Gambit142

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.

Qoosim commented 1 year ago

Status: Approved :tada: :heavy_check_mark:

Hi @team,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.