elad237
commented
1 year ago Hi @Nkaleth ✋
Your project is complete! There is nothing else to say other than... it's time to merge it: ship it: Congratulations! 🎉 👏 👏 💯
Highlights! Followed Gitflow ✔️ Linters are passing ✔️ Optional suggestions Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you consider them as they can improve your code.
- [ ] You can add an image of your leaderboard to display on your readme file
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread and tag me @1GORDON if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.
Hi @Nkaleth,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉
Highlights 💪
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @gealsanchez in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.