Nnoggie / MythicDungeonTools

World of Warcraft AddOn for planning and optimizing Mythic+ dungeon runs
GNU General Public License v2.0
331 stars 231 forks source link

Feature Request: Option for forces count instead of % in MDTSidePanel / MDTPullButton #549

Closed cschwier closed 7 months ago

cschwier commented 7 months ago

Hey, I would realy appreciate an option to switch the cummulative pull count in the side panel to optionally show forces count instead of percent. I hard coded this into my local version as a proof of concept. image

If you think this would be useful I would be willing to write a proper patch and file a pull request. If so: I found that there is still Reaping/Prideful code in the code base which renders the text in the MDTPullButton. Is this on purpose and should this stay or would it be okay to separate the coloring/affix highlighting from the count/percent to text rendering? I don't want to "clean something up" which is intended ^^