No-Bling / DOTA

winter is coming..
MIT License
206 stars 28 forks source link

Certain abilities that change hero model might not be GlanceValued(tm) #53

Closed Lethalmathematix closed 1 year ago

Lethalmathematix commented 4 years ago

Just played a game against this Undying where his ult form is not glancevalued.

And also spectated a game with Christmas-tree tiny who still had his decor on in the summer.

Screenshot 2020-07-14 at 2 45 44 AM
AveYo commented 4 years ago

I suspect hero replacement type of resources are overridden by the game coordinator just like it does for io arcana for example.
If that's the case, I will fallback to hard replacements of those resources.
Tomorrow I'm back in full force working on it.
Would help if you give me the match id so I can download it

Lethalmathematix commented 4 years ago

Undying: 5511807237

Tony model and Furion treants: 5512223382

Lethalmathematix commented 4 years ago

Also, check out Lycan ult and wolves (and also 'ol Tony) here: 5512458404

AveYo commented 4 years ago

I know, the script simply whitelists such models and the glancevalue option does not properly address that.
Now this is the kind of input I need because my testing possibilities are very limited, thank you!
No need for further examples or other such bug reports until after the next update.
I am working on it right now.