search

No9 / harmon

middleware for node-http-proxy to modify the remote website response with trumpet
Other
424 stars 62 forks source link

Issue to update NPM #5

Closed No9 closed 10 years ago

No9 commented 10 years ago

Raising this so I remember to republish to NPM following the commit from @fabiosantoscode

Also delighted to make @fabiosantoscode a collab with admin access to this repo.

OPEN open source FTW!!

fabiosantoscode commented 10 years ago

After vendoring the new version in fabiosantoscode/magicProxy, I think I've found a bug when the content-length of the response changes with the transforms. I'll try to add a test case tonight and fix that, so don't update npm just yet.

No9 commented 10 years ago

Hmmm careful here as buffering the whole response to get the length would be counter to the goal of the project which is not to buffer the whole response on the server. Willing to here the use case here though.

No9 commented 10 years ago

Closing as per the commit from @fabiosantoscode https://github.com/No9/harmon/commit/8a1a2f438a9886de2d2fa513f8629a459c742f58