NoAvailableAlias / nano-signal-slot

Pure C++17 Signals and Slots
MIT License
407 stars 60 forks source link

Feature/add cmake support #35

Open ClausKlein opened 2 years ago

ClausKlein commented 2 years ago

To be portable, I had to use catch2 instead of CppUnitTestFramework

NoAvailableAlias commented 2 years ago

Thank you for this PR as well as that opened issue (that is still to be reviewed...). I'm going to checkout ClausKlein/nano-signal-slot to see what I must do to my own workflow.

The only thing I can say is to possibly add some text in tests/readme concerning the need for catch2 and a link to it. This won't block the PR though, I'll add it post merge. Sorry for being extremely tardy.