search

NoAvailableAlias / nano-signal-slot

Pure C++17 Signals and Slots
MIT License
407 stars 60 forks source link

Can't compile under GCC 4.8 #4

Closed hyperiris closed 9 years ago

hyperiris commented 9 years ago

There is a compiler error in nano-signal-slot.hpp Line 39:

In file included from simple_test.cpp:1:0:

../nano_signal_slot.hpp:39:45: error: declaration of ‘using Function = class Nano::Function<T_rv(Args ...)>’ [-fpermissive]
     using Function = Function<T_rv(Args...)>;
                                             ^
In file included from ../nano_signal_slot.hpp:4:0,
                 from simple_test.cpp:1:
../nano_function.hpp:14:7: error: changes meaning of ‘Function’ from ‘class Nano::Function<T_rv(Args ...)>’ [-fpermissive]

changing this line to:

using Function0 = Function<T_rv(Args...)>;

and modify the following lines which use it will fix this.

NoAvailableAlias commented 9 years ago

This using declaration will be changed to prevent any possible shadowing issues. I will have to enforce my own testing checklists a bit more strictly. The issue will be closed when it's finished.