Fix Rails 5 deprecation

NoBrainerORM / nobrainer

Ruby ORM for RethinkDB

http://nobrainer.io/

Other

387 stars 49 forks source link

Fix Rails 5 deprecation #209

Closed jeroenvisser101 closed 8 years ago

jeroenvisser101 commented 8 years ago

Using ActiveSupport::Reloader instead of ActionDispatch::Reloader to be ready when Rails 5 hits (and to prevent it from breaking when 5.1 comes out).

DEPRECATION WARNING: to_prepare is deprecated and will be removed from Rails 5.1
(use ActiveSupport::Reloader.to_prepare instead) (called from block in <class:Railtie> at /path/to/lib/no_brainer/railtie.rb:29)

jeroenvisser101 commented 8 years ago

It seems that JRuby failing isn't connected to this PR.

jeroenvisser101 commented 8 years ago

Fixes #205

jeroenvisser101 commented 8 years ago

@nviennot it seems to break due to the secret key being empty on jruby, not sure about that. Do you mind checking this out?

jeroenvisser101 commented 8 years ago

There still seem to be some issues. In Rails 5, I keep getting the 'already registered and partially loaded' error, which I think is due to concurrent-ruby.

nviennot commented 8 years ago

Hi Jeroen :)

I removed jruby from travis-ci (even though the tests are running just fine locally). I don't think I want to troubleshoot the SSL erorrs it gives.
Merged the pull request
I can't reproduce the "already registered and partially loaded" error. If you want to open a new issue with some code to reproduce it, that'd be great :)

Thanks, Nico

jeroenvisser101 commented 8 years ago

@nviennot thanks for merging! Will see if I can get some code working next week. I've got a fork up that resolves the issue for me (not sure if it breaks other things though). If you want, you can have a look here.

nviennot commented 8 years ago

Thank you for the PR!

I'd be interesting in seeing the code that triggers the "partially loaded" error.