NoBrainerORM / nobrainer

Ruby ORM for RethinkDB
http://nobrainer.io/
Other
386 stars 49 forks source link

Add support for username and password authentication #213

Closed sixfeetover closed 8 years ago

sixfeetover commented 8 years ago

Fixes #200, and maintains support for auth keys. Also added tests for parsing URIs with and without usernames.

nviennot commented 8 years ago

Hey Jeff, thanks for the PR :)

I've modified your commit with the following:

The commit is https://github.com/nviennot/nobrainer/commit/0b3ca76449ae264d59df08af8c933ee248ac083d

Let me know if you approve as the commit is in your name :)

sixfeetover commented 8 years ago

Looks good to me! I wasn't sure how important it was to preserve auth key, so I took the conservative approach. Thanks for the quick review. :shipit:

nviennot commented 8 years ago

I looked at https://github.com/rethinkdb/rethinkdb/blob/next/drivers/ruby/lib/net.rb#L485 and though it wasn't :)