search

NoBrainerORM / nobrainer

Ruby ORM for RethinkDB
http://nobrainer.io/
Other
387 stars 49 forks source link

Added Array and TypedArray types for validation and serialization #264

Closed CodeMonkeySteve closed 3 years ago

zedtux commented 3 years ago

@CodeMonkeySteve I encourage you to rebase your branch on master as soon as my PR is merged as it fixes the issue you're facing with Travis.

CodeMonkeySteve commented 3 years ago

@zedtux Rebased, all checks passing, thanks!

zedtux commented 3 years ago

You're welcome !

zedtux commented 3 years ago

Hey @CodeMonkeySteve,

I'm now a maintainer of this gem and I'd like to get this PR merged. How can we do to get it ready to be merged? @nviennot can you please review answers from @CodeMonkeySteve?

Also you have now conflicts (sorry about that ... my bad :disappointed:). Can you please rebase on master?

CodeMonkeySteve commented 3 years ago

@zedtux congratulations/condolences on you promotion!

I've rebased against master, and all tests are passing. Should be good to go.

zedtux commented 3 years ago

This one LGTM, we will need a short update on the nobrainer.io repo too with this new feature.

Would you mind preparing something please?

CodeMonkeySteve commented 3 years ago

https://github.com/NoBrainerORM/nobrainer.io/pull/16

zedtux commented 3 years ago

I'll release the current unreleased stuff as of version 0.35.0 and then I'll release this PR as of version 0.36.0 this week.

zedtux commented 3 years ago

Thank you very much @CodeMonkeySteve for your contribution :+1: