NoCheatPlus / Issues

Issues managment for the NoCheatPlus project.
13 stars 9 forks source link

A check against HorseJump [DBO 751] #31

Open MyPictures opened 9 years ago

MyPictures commented 9 years ago

==What is the problem? What do you expect to see instead?== Some clients have a feature (known as HorseJump) that sets the "jump bar" when riding horses past full, allowing the player to execute a full power jump without waiting.

==Can it be reproduced systematically and if so: How?== Iridium has HorseJump

==How easy is it to reproduce? Does it always happen? Does it happen to all players? Does it happen with vanilla clients?== Easy to reproduce with the client. Happens if you have the module enabled on the client (not vanilla).

==Versions of NCP+MCAccess and server: Post the full output of the "ncp version" command!== Server: git-Bukkit-1.7.2-R0.3-2-g85f5776-b3023jnks (MC: 1.7.2) NoCheatPlus: Plugin: 3.10.12-SNAPSHOT-sMD5NET-b696 MCAccess: 1.7.2 / CB2922

==Details about the configuration file of NCP.== //(Examples: What version of NCP was the config generated with? Did you change anything - if so: add a quick description.)//\ Default config with build 696.

==Do you run any other special plugin next to NC+ (adding skills, machines, adding/changing blocks)?== //(Examples: SpoutPlugin, mcMMO, Heroes, MachinaCraft and others.)//\ None

==Please provide any additional information below!== //(Examples: Logs, screenshots, plugin list, player amount, NCP configuration files ... use http://dev.bukkit.org/paste/ or http://pastebin.com/ and add the link here if linked resources are longer than a few lines.)//\ Only public client with this functionality is Iridium (that I am aware of)... Video demonstration: https://www.youtube.com/watch?v=8eSY_mFUbTQ

MyPictures commented 9 years ago

MyPictures: "That is not possible to detect/block because its a fully client-sided hack."

MyPictures commented 9 years ago

asofold: "MyPictures:

That's a kind of "temporarily impossible"... currently i don't know of Bukkit horse-jumping events. It would be a similar problem to pulling the string of a bow, though i think horse jumping is slightly faster.

It might/should be possible once Bukkit adds an event (horse jump + jump-bar-amount") or once we add packet level checks (e.g. depending on ProtocolLib).2"

MyPictures commented 9 years ago

asofold: "asofold:

No I think they literally just charge the "horse jump" up as its intended to be. The only difference here is that instead of having to hold the space bar and release at a perfect time you just press it once and it will charge up to the perfect jump level."

MyPictures commented 9 years ago

ProdigyOG: "MyPictures:

If you watch the video I posted above, you can see that not only is the jump bar past full, it doesn't go down to 0 after jumping. So the client isn't charging the horse jump bar in a vanilla fashion."

MyPictures commented 9 years ago

asofold: "MyPictures: ProdigyOG:

I'd assume that it's some "instant jump" thing."

asofold commented 8 years ago

Packet level + timing i guess.

asofold commented 8 years ago

Horse fly checks may bring such in-range. The difficulty of implementation i'm not sure about, as you can move freely while letting the jump bar fill.

What we could easily detect is repeated (high) jumping without pauses. This should at least wait until we monitor the jump height more precisely by the jump attribute, though.