search

NoCheatPlus / Issues

Issues managment for the NoCheatPlus project.
13 stars 9 forks source link

FastConsume event not updating hunger [DBO 753] #32

Open MyPictures opened 8 years ago

MyPictures commented 8 years ago

==What is the problem? What do you expect to see instead?== If a player fails the FastConsume check, the player's hunger bar will reflect that s/he ate the consumable. The hunger bar only reflects the true value when it changes again.

==Can it be reproduced systematically and if so: How?== Have a client with FastEat. Turn it on and eat some food. You will see that the player will fail the FastConsume checks, but their hunger bar will increase as if they ate the food legitimately. The hunger bar only shows the true value when another FoodLevelChangeEvent is fired.

==How easy is it to reproduce? Does it always happen? Does it happen to all players? Does it happen with vanilla clients?== Easy to reproduce with a client w/ this feature. If you don't have this feature, here is some source code: http://pastebin.com/w1FiT6jX

==Versions of NCP+MCAccess and server: Post the full output of the "ncp version" command!== Server: git-Bukkit-1.7.9-R0.1-b3084jnks (MC: 1.7.9) NoCheatPlus: Plugin: 3.10.12-RC-sMD5NET-b700 MCAccess: 1.7.8|1.7.9 / CB3043-DEV

==Details about the configuration file of NCP.== //(Examples: What version of NCP was the config generated with? Did you change anything - if so: add a quick description.)//\ Default on Build 700.

==Do you run any other special plugin next to NC+ (adding skills, machines, adding/changing blocks)?== //(Examples: SpoutPlugin, mcMMO, Heroes, MachinaCraft and others.)//\ No.

MyPictures commented 8 years ago

MyPictures: "Yea we had this issue once. I think the needed Bukkit Event didn't properly update if a plugin canceled it, we had a temp fix which basically forced the hunger bar to update. Not sure if its broken now."

MyPictures commented 8 years ago

ProdigyOG: "ProdigyOG:

NCP should send an updateInventory call, otherwise i am not sure if we can do much about it, except hacks, like setting health higher for one tick and then setting it lower again."

MyPictures commented 8 years ago

ProdigyOG: "asofold:

Isn't updateInventory() deprecated, though?"

MyPictures commented 8 years ago

asofold: "ProdigyOG:

Deprecated yes, but not yet removed. Bassically it's deprecated, because it is a dirty workaround for some "more complex issue"."

MyPictures commented 8 years ago

asofold: "Has this been fixed server-side already?"