Nocheatplus resourcepack issue

ghost commented 6 years ago

I am using the latest version of paper spigot snapshot version 1.12.2 release 1337 and whenever i start the server me or other players will join the server run around for about 15-30 seconds and then be kicked due to keepalive timeout. I've experienced the issue myself in game. If i use plugman to disable protocol lib or load server w/o it then nocheatplus cant check for packets and i can play just fine. I am also using a server resourcepack if that helps. i've found that disabling keepalive frequency in the config.yml fixes the issue. please fix as i want a custom resourcepack on my server but dont want to have hackers just changing their resourcepack to xray diamonds.

MarkElf commented 6 years ago

Resource packs are client sided, they have no impact as far as in-game checks. It's more than likely a conflicting plugin or player latency (ping).

asofold commented 6 years ago

Resource packs that are downloaded from the server might increase the time which the client needs to render - i currently don't know if this also increases the time the client needs to answer a keep-alive packet. This would only go for players who just join(-ed).

I could use more information:

Complete output of /ncp version.
Other plugins relating to NCP / ProtocolLib / Obfuscation?
Side conditions:
- Does this happen after a clean restart?
- Does this happen to all players always?
  - Does it only happen to players who are online after reloading, or does also it happen to players who join a little longer after restart/reloading (/reloading plugins)?

Janmm14 commented 6 years ago

As far as I know: Resource pack loading holds the main thread and therefore all packet related stuff since it is scheduled on the main thread.

ghost commented 6 years ago

Nope nocheatplus+protocollib is all i use. im not too big on anticheat because it ruins the feel of the game to have restrictions everywhere (if some random player uses fullbright i dont really care too much i just dont want people flying everywhere). It does happen after a clean restart and happens to almost all players( i think the ones without the issue have resourcepacks disabled) also i dont reload the server i use a plugin management plugin. My server is home hosted so /restart is useless. Usually i do not touch plugins, I never use the /reload command because its not supported. I've had issues with the server literally breaking so i stopped. I sometimes reload plugins while in game using its given reload command or by using plugman (only when configuring plugins configuring plugins then i COMPLETELY stop and start the server). Im not saying this is 100% an issue with nocheatplus im also working with protocollib to see if it could be them. just sayin... here is the output of /ncp version: 10:42:31 INFO: ---- Version information ---- 10:42:31 INFO: #### Server #### 10:42:31 INFO: git-Paper-1337 ~MC: 1.12.2~ 10:42:31 INFO: detected: 1.12.2 10:42:31 INFO: #### NoCheatPlus #### 10:42:31 INFO: Plugin: 3.16.0-RC-sMD5NET-b1134 10:42:31 INFO: MCAccess: 1.12-1.12.2 / Spigot-CB-1.12_R1

asofold commented 6 years ago

If the issue only happens just after joining, the appropriate adjustment could simply be a "delay after join" thing, i.e. not trigger the check until a configured delay has passed after a player has joined.

'Simply' means that i have to first finish the batch of changes currently in the queue. Next bigger change i might run on a branch, so smaller fixes can still be pushed quickly without merging, but currently i have to put things together so the plugin compiles at all (internal data storage and registration changes).

NoCheatPlus / Issues

Nocheatplus resourcepack issue #518