search

NoCheatPlus / Issues

Issues managment for the NoCheatPlus project.
13 stars 9 forks source link

NoCheatPlus conflict with Magic #577

Open Blamo27 opened 6 years ago

Blamo27 commented 6 years ago

Hello,

We're using the plugin Magic, that adds, amongst others, a spell called "glide" that allows you to glide like you would with elytrae, but without having some.

NCP survival fly protection prevents players from gliding using that spell. That is odd, considering that, on the other hand, players can use a spell called "fly" that allows them to fly like in creative.

Do you think you could work on a fix / an exception for that spell ? Thank you.

Complete output of the ncp version command.

3.16.0-RC-sMD5NET-b1134

How to reproduce the issue ?

Cast the "fly" spell of the Magic plugin on a player.

Do you run any other special plugins that affect game mechanics next to NC+ ?

Magic in this case. (https://www.spigotmc.org/resources/magic.1056/)

Provide additional information, such as error/debug/violation logs.

NoCheatPlus moving violation.

0-x-2-2 commented 6 years ago

The creator of the plugin should fix it.

NathanWolf commented 6 years ago

Will adding a timed flight exemption be enough to chill NCP?

0-x-2-2 commented 6 years ago

NCP does have a api for plugins to use I think?

NathanWolf commented 6 years ago

Yes, and I use it, I just didn't think I had to add flight exceptions for vanilla gliding.

I've added one now, I guess I'll wait and see if that fixes the problem.

Blamo27 commented 6 years ago

@NathanWolf @0-x-2-2

NCP is still preventing user that is trying to use this spell. As you can see in the screen below :

image

NathanWolf commented 6 years ago

I added a flight exemption. If NCP is tagging vanilla gliding as “creative flight” I’m not really going to do anything else about that.

0-x-2-2 commented 6 years ago

You are only doing survival_fly exemption if a player has vanilla flight enabled it will use the creative_fly check instead.

NathanWolf commented 6 years ago

I will try that, but to be clear I think the problem is gliding, not flying.

0-x-2-2 commented 6 years ago

Creative_fly is the check used for Elytra's too I think?

NathanWolf commented 6 years ago

Ok thanks, we'll give it a try!

@Blamo27 - unfortunately I'm out of town for the holidays and my build server seems to have gone down. So I made the fix, but it may be a week or two before you can get it.

Blamo27 commented 6 years ago

@NathanWolf I can build it and test it if you want

NathanWolf commented 6 years ago

Sure that'd be great- the fix is pushed. I'm just adding exemptions for both creative and survival fly now.

Blamo27 commented 6 years ago

Okey nice, I will test it tomorrow !