Open ryandis44 opened 8 years ago
Forget about the general questions:
(For reference you could activate the allviolations hook to log all violations (...), on reproducing the issue every single violation will be printed (depending on settings, to the log file and/or ingame). It's not as heavy as debug logging, though it prints all violations of all players.)
Issues on implementation side:
Looks like i have to change/fix this check.
I'm running git-Spigot-db6de12-18fbb24, and I have made sure that the violation level is not accumulating. I checked the player's violation levels with ncp info after removing the player with ncp remove, and the level after being kicked was lower than 100, so the player should not have been kicked; and I took ncp info for reference because NCP is not notifying me in-game of VL updates on a player- I would have enabled debug but I forgot about it.
However, I did update shortterm and normal to 64 each and it seems to have somewhat fixed it (look at the video).
Video (Ignore the music. My sister rick rolled me): https://www.youtube.com/watch?v=og0Ud5hYJDg&feature=youtu.be
The shortterm part kicks in for 4 ticks instead of 20 (normal limit), so it could have an effect. (This means, that violations with 40 clicks arriving within 4 ticks, having the shortterm limit set at 4, could lead to something below 40 * 36 violation level, so that would be above 1000!). Maybe i misjudged the code, but with the latest review i assume the level doesn't decrease anyway, so at some point you'd get over any actions threshold, provided you violate the check (not with slow clicking).
The video isn't available here, due to the music :p.
Lol. I'll re upload it without the music On Tue, Feb 9, 2016 at 6:33 AM asofold notifications@github.com wrote:
The shortterm part kicks in for 4 ticks instead of 20 (normal limit), so it could have an effect.
The video isn't available here, due to the music :p.
— Reply to this email directly or view it on GitHub https://github.com/NoCheatPlus/Issues/issues/85#issuecomment-181846030.
Sorry for the late response. Been busy all day.
I found another bug while I was re-recording, so then I re-re-recorded. Lol. Here it is (without the music): https://www.youtube.com/watch?v=bUF1PmBCCkY&feature=youtu.be
Found another bug. The Null hack client (http://www.wizardhax.com/2016/01/06/minecraft-null-1-8-1-8-9-hacked-client-optifine-download/) bypasses Sneak and Jesus on NoCheatPlus. NCP doesn't notice the cheats at all. For the Jesus bypass, I think they are sending "swim" packets to the server, so the server thinks they are swimming- or jumping out of the water, therefore they are not kicked. I'm not quite sure how sneak is being bypassed though. (I have looked into the NCP code a little bit, but I can't seem to fix it- as I am just starting Java.)
Video: https://www.youtube.com/watch?v=zvQ6D4TV_dY&feature=youtu.be
I'll check out the videos some time soon.
Please consider searching the issues for things like jesus and sneak :): Jesus: https://github.com/NoCheatPlus/Issues/issues/34
We regard the hack as not so important, concerning staying on water without spamming the jump key. The speeding aspect we assign to the speeding issues: https://github.com/NoCheatPlus/Issues/issues/7
Concerning sneaking, they just seem to unsneak before moving, then sneak again after having sent their new position - in effect they'll not be sneaking during PlayerMoveEvent processing server-side. There is no (public) ticket about that yet, but we'll be able to contain such, e.g. with monitoring frequency of moving after unsneak.
Sorry about that. I got so tied up and forgot to check. On Wed, Feb 10, 2016 at 3:46 AM asofold notifications@github.com wrote:
I'll check out the videos some time soon.
Please consider searching the issues for things like jesus and sneak :): Jesus: #34 https://github.com/NoCheatPlus/Issues/issues/34
We regard the hack as not so important, concerning staying on water without spamming the jump key. The speeding aspect we assign to the speeding issues: #7 https://github.com/NoCheatPlus/Issues/issues/7
Concerning sneaking, they just seem to unsneak before moving, then sneak again after having sent their new position - in effect they'll not be sneaking during PlayerMoveEvent processing server-side. There is no (public) ticket about that yet, but we'll be able to contain such, e.g. with monitoring frequency of moving after unsneak.
— Reply to this email directly or view it on GitHub https://github.com/NoCheatPlus/Issues/issues/85#issuecomment-182281607.
Hello. I'm running the latest version of NCP (3.13.7-RC-sMD5NET-b925) on my servers.
When I double click an item in my inventory, I get kicked for fast click, which is what I have it set up to do. However, NCP is not reporting a violation level to admins, and it's kicking at a very low level.
Here's what I have set up: fastclick: active: true sparecreative: true tweaks1_5: true limit: shortterm: 4 normal: 15 actions: cancel vl>1000 log:fastclick:3:10:cif cancel cmd:lightning cmd:lightning cmd:lightning cmd:smoke cmd:kickfastclick
I've tried tweaking this and even resetting my config and it still kicks players. The only way to fix it is to do: action: cancel
Upon fast clicking, the player will be kicked and sent to the lobby if their violation level is above 1,000. However, NCP is kicking for double clicking in the inventory (I can record a video if you need) with a violation level of >100.