search

NoCode-NoLife / melia

Open-Source MMORPG Server Emulator
GNU General Public License v3.0
264 stars 94 forks source link

Skill Power / Speed customization #316

Closed Terotrous closed 3 weeks ago

Terotrous commented 1 month ago

Gives the ability to quickly customize skill factors and enemy skill speed.

exectails commented 3 weeks ago

Truth be told, I don't know about this PR. It feels a bit too improvised, for lack of a better word, and it modifies values we arguably don't even fully understand yet. Meanwhile it introduces new questions, like what even qualifies as a "monster", which we might have a hard time adding exceptions for down the line without hacks.

Additionally, it seems to me like one could do way more with this, or rather, that simple multipliers will likely never cut it to truly customize skill factors and delays across all skills and monsters, which means users and content packs will have to use scripting or core mods to gain more control anyway.

I will merge it for now, while we still figure out how we want things to work, but I think there's a good chance we may remove these options again at some point. But at least we now have the calls and scriptable functions that would be needed to modify these values.

Terotrous commented 3 weeks ago

I generally agree with the idea that some parts of this could end up being temporary, but I think it's useful for now to be able to put the game into a state of drastically better balance by editing a single file. It certainly makes skill development a lot easier when I don't have to manually set the skill factors for every skill during testing.