NoCode-NoLife / melia

Open-Source MMORPG Server Emulator
GNU General Public License v3.0
264 stars 94 forks source link

SklSpdRate #318

Open Terotrous opened 4 weeks ago

Terotrous commented 4 weeks ago

This stat effectively seems to function similarly to attack speed, where it speeds up your attack animations, but currently none of our skill handlers account for this. Do we need to create a method to auto-adjust your delay calls using this value?

exectails commented 4 weeks ago

That's a very good question. There aren't that many skills that are affected by the speed rate data, but they do exist, so the answer is most likely yes. We could technically include them only in the skills that need them, but since it's based on easily editable data, we should certainly consider including it in all of them. Though we'd want to add a simpler way to get and calculate them than what we did in the melee ground handler.

Terotrous commented 4 weeks ago

How do we know which ones are affected by it? Does the description mention it?

exectails commented 4 weeks ago

By default, SklSpdRate is potentially affected by three things: the skill's speed rate, dex, and buffs, though the latter two only if the respective toggles in the skill data are on. So if a skill has a speed rate of 1 (no change) and both speedRateAffectedByDex and speedRateAffectedByBuff are false, the skill doesn't need the speed rate adjustment, unless someone modifies the values. In total there are ~150 skills currently using this.