Force trailing slash when page is loaded - Githubissues

NoDivide / astrum

A lightweight pattern library designed to be included with any web project.

http://astrum.nodividestudio.com

1.54k stars 98 forks source link

Force trailing slash when page is loaded #143

Closed corneliusio closed 6 years ago

corneliusio commented 6 years ago

What does this PR cover?

When loading the pattern library root, if there is no trailing slash on the path name, then app/js/main.min.js will not load and the app breaks.

I've just added a tiny check in the <head> that forces the trailing slash if it is not present. Does not redirect or mess with hashes.

Screenshot

broken app w/o trailing slash

What gif best describes how you feel about this work?

Reviewers

Review 1

[ ] :+1:

Review 2 (optional)

[ ] :+1:

By adding a +1 you are confirming you have...

Witnessed the work behaving as expected (this could be on the author's machine or screencast).
Checked for coding anti-patterns.