NoDivide / astrum

A lightweight pattern library designed to be included with any web project.
http://astrum.nodividestudio.com
1.54k stars 98 forks source link

Set the default option for a new group as 'Position after {last}' #146

Closed Andy-set-studio closed 6 years ago

Andy-set-studio commented 6 years ago

What does this PR cover?

This is to fix #141.

How can this be tested?

Screenshots / Screencast

astrum-ss

What gif best describes how you feel about this work?

Kenan from "Kenan and Kel" likes the smell of what's on his plate


Reviewers

Review 1

Review 2 (optional)

By adding a +1 you are confirming you have...


RyanHavoc commented 6 years ago

@hankchizljaw This looks good for groups. Do components already position last in a group?

Andy-set-studio commented 6 years ago

Yeh I stole your approach 😉.

Andy-set-studio commented 6 years ago

After completely over-engineering it on the first pass of course...

RyanHavoc commented 6 years ago

@hankchizljaw Ah, awesome. Make sense. :-)