Where a custom library_title is set, make sure it takes precedence ov…

Andy-set-studio commented 6 years ago

…er 'Pattern library'

What does this PR cover?

This PR fixes #104

How can this be tested?

Init Astrum
Create at least one component
Open it in your browser and notice all the refs to 'Pattern library'
Change theme.titles.library_title in data.json to something like 'Custom title'
Refresh your browser and see the refs have change to 'Custom title'
Celebrate enthusiastically

Screenshots / Screencast

nov-24-2017 16-42-58

What gif best describes how you feel about this work?

Soccer coach giving the thumbs up

Reviewers

Review 1

[ ] :+1:

Review 2 (optional)

[ ] :+1:

By adding a +1 you are confirming you have...

Witnessed the work behaving as expected (this could be on the author's machine or screencast).
Checked for coding anti-patterns.

RyanHavoc commented 6 years ago

FYI this has already been resolved in release/2.0.0.

Andy-set-studio commented 6 years ago

I get ya @giothevanni,

With fresh eyes, this and your PR in my branch are possibly getting a bit unreadable to a new contributor. I think a computed property / method rather than ternary statements maybe be more useful. I’m always mindful that we don’t make it difficult to get involved in Astrum. Abstracting this to JS code will help it scale too 🙂.

If this is fixed in 2.0.0, @RyanHavoc, shall we bail on this bug fix and work on that implementation instead?

Thanks again, @giothevanni!

RyanHavoc commented 6 years ago

@hankchizljaw I think it would make sense to yeah.

NoDivide / astrum