NoDivide / astrum

A lightweight pattern library designed to be included with any web project.
http://astrum.nodividestudio.com
1.54k stars 98 forks source link

Change Vue mode to production (and update webpack in the process) #162

Open giothevanni opened 6 years ago

giothevanni commented 6 years ago

What does this PR cover?

Fixing #129 and updating 2 major releases of webpack in the process (from 2 to 4)

Sources:

How can this be tested?

Install astrum and the "development mode" console warning should be gone.

Screenshots / Screencast

screen shot 2018-03-28 at 21 54 19

What gif best describes how you feel about this work?


Reviewers

Review 1

Review 2 (optional)

By adding a +1 you are confirming you have...


giothevanni commented 6 years ago

Hey @RyanHavoc & @hankchizljaw , finally got around to fixing this. It turned out to be a much bigger change than I anticipated. I'll be looking forward to your feedback.

Cheers!

Andy-set-studio commented 6 years ago

Hey @giothevanni! Thanks for your hard work. We'll take a look at this next week 🙂

giothevanni commented 6 years ago

Hey guys, have you had the chance to take a look at this one?