predicates adapter no longer returns array of selected `Resource`s, just selected URI strings

NoLiD / Disquo

Data comparator for humans.

1 stars 1 forks source link

predicates adapter no longer returns array of selected `Resource`s, just selected URI strings #15

Closed kdbanman closed 9 years ago

kdbanman commented 9 years ago

The problem is noticeable with the results of this section.

Rather than iterating through a list of resources with a .get('label'), it just iterates through URI strings.

xkb commented 9 years ago

It never was a list of Resources because 'selected' is a list of what's being passed around the URL. We have to query again for labels because we can't assume they've have been already fetched i.e. someone shares a link to 'this' URL.

This is also the case where a global uri based cache would be useful.

kdbanman commented 9 years ago

Right, sorry. I remember talking about that now. Looking back at previous commits, it seems I never was getting the labels of the selected URIs, only the predicates returned by the query.