GRASP-12948 Add accepted http response statuses for http methods

NoMagicAi / abb_librws

A C++ library for interfacing with ABB robot controllers supporting Robot Web Services

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

GRASP-12948 Add accepted http response statuses for http methods #46

Closed makotecki closed 2 years ago

makotecki commented 2 years ago

Changed http methods for RWSClient from having hardcoded expected http response codes to being passed by optional argument. Existing codes are left as default.

https://nomagic.atlassian.net/browse/GRASP-12948

Review @michalvi @mkatliar

How it was tested? On virtual robot through myke script.

makotecki commented 2 years ago

I've run it on the Hugo simulation on virtual machine following Simplified robot studio for simulation instructions. Worked fine.

Those http methods are basically the same, consolidating them would be the appropriate way to go, but it would require some work. I'll create an issue for this.

krzyfre commented 2 years ago

This merged branch breaks the build of abb_librws. There are some typos for example: Poco::Het::HTTPResponse::HTTP_OK}`` instead ofPoco::Net::HTTPResponse::HTTP_OK}```