search

NoMagicAi / abb_librws

A C++ library for interfacing with ABB robot controllers supporting Robot Web Services
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

GRASP-12948 Typo bugfix #47

Closed makotecki closed 2 years ago

makotecki commented 2 years ago

Fix of typo in rws_client.h.

Tested on hugo simulation in virtual machine.

mkatliar commented 2 years ago

How did it compile with that typo?

makotecki commented 2 years ago

It did not. I must have made a mistake when replacing commit id of abb_librws in docker file as currently it has to be done manually.

mkatliar commented 2 years ago

it has to be done manually.

There has been an issue for this for a long time: https://nomagic.atlassian.net/browse/DEVOPS-1981 But devops have not started working on it yet. Maybe you could push them as well? And vote for the issue, indicating that it is not only me who needs it?

makotecki commented 2 years ago

Sure, i voted for the issue. There is really no mechanism now to detect such mistakes. In the meantime I just prepared an alias command that changes the hash when I make changes on this repo so it won't happen to me again, but for newcomers like me there is not much information on how to prevent and watch out for such mistakes.