GRASP-12403 Polling progress of configuration loading from robot - Githubissues

NoMagicAi / abb_librws

A C++ library for interfacing with ABB robot controllers supporting Robot Web Services

BSD 3-Clause "New" or "Revised" License

0 stars 5 forks source link

GRASP-12403 Polling progress of configuration loading from robot #50

Closed makotecki closed 2 years ago

makotecki commented 2 years ago

Closed by mistake previous PR.

Changes:

add polling progress resource
changed loadCFGFile method to return progress id
implemented and tested xmlNodeTextByTagAndAttribute in parsing.cpp Implemented both V1 and V2 protocol but tested only V2.

How it was tested?

Tested using ConfigurationUploader.cpp GRASP-12403 on LAB-Hugo robot in virtual machine using monomagic PR 9922. Tested scenarios:

Normal configuration upload resulting in normal operation
Large file upload, so it takes time to process it resulting in "pending" progress state
Invalid cfg file upload resulting in progress response state "ready" and an error code (code < 0)

Additional tests:

Checking progress of invalid resource (random progress id) results in bad request exception
Checking error code by invalid code results in bad request exception

To check:

Not sure if getProgress is in right place. Should it be outside rws_client, i.e. separate namespace and progress.cpp?
Removed Resource::PROGRESS constant from header and source, but left all other - should it be separate issue to clean them up?