NoMoreFood / putty-cac

Windows Secure Shell Client With Support For Smart Cards, Certificates, & FIDO Keys
469 stars 43 forks source link

Pageant crashes when "cert/key auth promting" is enabled #88

Closed DonEstefan closed 2 years ago

DonEstefan commented 2 years ago

Steps to reproduce

  1. start pageant and load putty key from disk
  2. make sure "cert/key auth promting" is enabled in pageant
  3. open an ssh connection to a linux box -> pageant asks to allow signing operation -> say yes -> ssh connection succeeds
  4. close the ssh connection
  5. open ssh connection again -> pageant asks to allow signing operation -> say yes => pageant crashes before signing succeeds

Crashes do not happen with disabled "cert/key auth promting" I'm using putty-cac 0.76-3 on win10 21H2

NoMoreFood commented 2 years ago

Just to confirm - this is specifically PuTTY keys? When the second auth prompt occurs, does the comment on the key display properly?

DonEstefan commented 2 years ago

I only tested using .ppk key files. I have not tested certificates or anything else. And yes, the second signing prompt displays properly. Pageant also crashed if I choose "no" on the second prompt.

DonEstefan commented 2 years ago

The key's "comment" in the second popup is the same as in the first.

NoMoreFood commented 2 years ago

Please see if the latest binaries posted here addresses the behavior: https://github.com/NoMoreFood/putty-cac/tree/master/binaries

DonEstefan commented 2 years ago

I did a quick test using the new pageant stand-alone binary from here (0.76u4) and it fixes my issue 👍 Thanks a lot!!!