NoRedInk / rspec-retry

retry randomly failing rspec example
MIT License
585 stars 96 forks source link

"Retry count" is really a try count #11

Open p-originate opened 10 years ago

p-originate commented 10 years ago

Retry count appears to be misnamed and is actually an attempt/try count.

retry count = 0: example is not run at all.

retry count = 1: example is run once (no retry).

retry count = 2: example is run once, and if fails, is retried once.

bethanyvwatson commented 10 years ago

After being confused by this too, I submitted a PR that uses 'try_count' instead. https://github.com/y310/rspec-retry/pull/14

[edited: changed 'attempt' to 'try' so it keep the spirit of 'rspec-retry']

justin808 commented 10 years ago

I'd agree with this. I once made the mistake of using a count of zero!

rdlugosz commented 10 years ago

:+1:

fabn commented 9 years ago

+1 for this, it's pretty confusing.

ilyakatz commented 9 years ago

+1

CacheControl commented 9 years ago

:+1: current terminology is confusing

michaelglass commented 9 years ago

We'll change this momentarily. Breaking change so will call the next version 1.0.0

bootstraponline commented 9 years ago

:+1:

philipfong commented 9 years ago

:+1: