NoSubstitute / scrviz-profile

Kim Nilsson's profile for scrviz - https://scrviz.web.app
1 stars 0 forks source link

loginname is case sensitive #1

Open brucemcpherson opened 3 years ago

brucemcpherson commented 3 years ago

Hi Kim

thanks for creating a scrviz-profile. It was rejected at build. Note that the login name is case sensitive and should exactly match your Github loginname - this is a security thing to prevent people updating profiles they don't own.

If you fix it on github it'll get digested at the next update.

cheers bruce

NoSubstitute commented 3 years ago

Fixed it! Thanks.

brucemcpherson commented 3 years ago

Hi Kim

almost there. In the repo section, the only ones it will include are repos with an appsscript.json manifest. These ones are mentioned in your profile, but the repos are not appsscript.json ones. It's not a problem - it just means they'll be ignored because they are obviously not in the viz.

failed to find scrviz profile repo NoSubstitute/CB_ShowDetails failed to find scrviz profile repo NoSubstitute/SPOGOU failed to find scrviz profile repo NoSubstitute/gamUploader

cheers bruce

On Tue, 16 Mar 2021 at 15:59, Kim Nilsson @.***> wrote:

Closed #1 https://github.com/NoSubstitute/scrviz-profile/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#event-4465464818, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBGM3PDHXX2HZLHBRWTTD5555ANCNFSM4ZIZK26Q .

NoSubstitute commented 3 years ago

Ah, yes, I have probably only added an appsscript.json to CB_Inventory so far. :-) SPGOU and CB_ShowDetails will get jsons. And gamUploader isn't GAS at all, so I should remove that completely, right? I mean if your tool is to list GAS projects only?

brucemcpherson commented 3 years ago

Up to you. It’ll just ignore them anyway, so no harm. On Tue, Mar 16, 2021 at 7:10 PM Kim Nilsson @.***> wrote:

Reopened #1 https://github.com/NoSubstitute/scrviz-profile/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#event-4466434287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBHCUT5NY7LBOKDCUF3TD6UKVANCNFSM4ZIZK26Q .

brucemcpherson commented 3 years ago

https://scrviz.web.app/?owner=NoSubstitute

On Tue, 16 Mar 2021 at 19:23, Bruce Mcpherson @.***> wrote:

Up to you. It’ll just ignore them anyway, so no harm. On Tue, Mar 16, 2021 at 7:10 PM Kim Nilsson @.***> wrote:

Reopened #1 https://github.com/NoSubstitute/scrviz-profile/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#event-4466434287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBHCUT5NY7LBOKDCUF3TD6UKVANCNFSM4ZIZK26Q .

brucemcpherson commented 3 years ago

Now also supports tags in the owner card [image: image.png]

On Wed, 17 Mar 2021 at 14:04, Bruce Mcpherson @.***> wrote:

https://scrviz.web.app/?owner=NoSubstitute

On Tue, 16 Mar 2021 at 19:23, Bruce Mcpherson @.***> wrote:

Up to you. It’ll just ignore them anyway, so no harm. On Tue, Mar 16, 2021 at 7:10 PM Kim Nilsson @.***> wrote:

Reopened #1 https://github.com/NoSubstitute/scrviz-profile/issues/1.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#event-4466434287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBHCUT5NY7LBOKDCUF3TD6UKVANCNFSM4ZIZK26Q .

NoSubstitute commented 3 years ago

Ah, that's nice.Thanks for the follow-up. But, I don't see the image use in your documentation, nor in your own json.Or don't you actually use the json here https://github.com/brucemcpherson/scrviz-profile/blob/main/scrviz-profile.json ?

/Kim

brucemcpherson commented 3 years ago

Yes I use that. Which image do you mean?

On Thu, Mar 18, 2021 at 8:30 AM Kim Nilsson @.***> wrote:

Ah, that's nice.Thanks for the follow-up. But, I don't see the image use in your documentation, nor in your own json.Or don't you actually use the json here < https://github.com/brucemcpherson/scrviz-profile/blob/main/scrviz-profile.json

?

/Kim

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#issuecomment-801731977, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBF6AB6MZUKVSIWFTBDTEG23RANCNFSM4ZIZK26Q .

NoSubstitute commented 3 years ago

I meant, I don't see you using the image tag anywhere in your json.

brucemcpherson commented 3 years ago

the tag icon is fixed and not configurable and simply introduced the tags from the profile. [image: image.png]

I'm going to add this to repos (and probably projects too) shortly.

On Thu, 18 Mar 2021 at 13:03, Kim Nilsson @.***> wrote:

I meant, I don't see you using the image tag anywhere in your json.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#issuecomment-801909143, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBGCGOKLWBZFDUTK64DTEH2YLANCNFSM4ZIZK26Q .

NoSubstitute commented 3 years ago

hahaha, no I was confused by this bit in your message.

[image: image.png]

That's what I meant. I thought you were talking about a special tag to show actual images. I had understood the tag references to icons. Sorry.

brucemcpherson commented 3 years ago

No problem, thanks!

On Thu, 18 Mar 2021 at 15:24, Kim Nilsson @.***> wrote:

hahaha, no I was confused by this bit in your message.

[image: image.png]

That's what I meant. I thought you were talking about a special tag to show actual images. I had understood the tag references to icons. Sorry.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/NoSubstitute/scrviz-profile/issues/1#issuecomment-802017732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOONBAAV5LF5KROMUCUYGLTEILLJANCNFSM4ZIZK26Q .