NoUmlautsAllowed / gocook

Alternative frontend to Chefkoch. This is a repository mirror from Codeberg.
https://codeberg.org/NoUmlautsAllowed/gocook
MIT License
22 stars 0 forks source link

Some fixes to pagination #20

Closed qwerty287 closed 7 months ago

qwerty287 commented 7 months ago
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 41.31%. Comparing base (4bd5b3d) to head (c00554c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #20 +/- ## ======================================= Coverage 41.31% 41.31% ======================================= Files 12 12 Lines 472 472 ======================================= Hits 195 195 Misses 269 269 Partials 8 8 ``` | [Flag](https://app.codecov.io/gh/NoUmlautsAllowed/gocook/pull/20/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Ξ” | | |---|---|---| | [unittests](https://app.codecov.io/gh/NoUmlautsAllowed/gocook/pull/20/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `41.31% <100.00%> (ΓΈ)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qwerty287 commented 7 months ago

Just leave a comment if you like to improve this, otherwise I am happy to merge this as is πŸ‘

I can try it, but I won't do it today, maybe tomorrow.

Happy Easter 🐰

Thanks, happy Easter back πŸ™ƒ

qwerty287 commented 7 months ago

I tried fixing this now, but maybe it's better to keep it how it's now. Adding these special cases for 6 and 7 pages in total will add much more code and tbh this pagination was already pretty hard to understand :laughing: So I'd rather not make it more complicated and keep this edge-case.