Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
74 stars 24 forks source link

Custom rendered armor pieces incompatible with VanitySlots and SimpleHats #131

Closed KuwuroUsagi closed 1 year ago

KuwuroUsagi commented 1 year ago

Mythic Metal items using custom rendering don't accurately show/hide when using certain items intended to hide the model (Familiar Wig from VanitySlots, or any hat from SimpleHats) I've experienced this only with the Metallurgium Helmet, but I've heard there could possibly be other pieces of armor of other metal variants that may use the same rendering process.

javaw_2022-11-09_01-12-54

Noaaan commented 1 year ago

I am still looking into compatabilty with SimpleHats, but for Armor I would recommend using Cosmetic Armor instead: https://www.curseforge.com/minecraft/mc-mods/cosmetic-armor-fabric Their implementation of the armor rendering is a bit simpler, and correctly overrides armor when worn in the slot.

itsdinkd commented 1 year ago

I am still looking into compatabilty with SimpleHats, but for Armor I would recommend using Cosmetic Armor instead: https://www.curseforge.com/minecraft/mc-mods/cosmetic-armor-fabric Their implementation of the armor rendering is a bit simpler, and correctly overrides armor when worn in the slot.

Cosmetic armor is very buggy and the developer doesnt really update it, ever. Check comments on modpage.

Noaaan commented 1 year ago

Hey, sorry for the long wait on a response on this issue. It ended up in my backlog, and frankly, after Nyako implementing support for VanitySlots I wrote this off as a non-issue, since I believe it is up to SimpleHats to implement support for Fabrics ArmorRenderer. I know a handful of mods use it, like Spectrum and Twilight Forest, so it would generally make more sense for them to fix it. I also kinda like how the hats interact with the armor, so therefore I think its best to close this issue. Thanks for reporting! image