search

Noaaan / MythicMetals

Fabric based Minecraft mod that adds new materials into the game. Includes new tools, ores, anvils, and sets of armor.
Other
72 stars 24 forks source link

Compatibility - MMv1.18.0/1.18.1 & RER 2.8.0 #179

Closed rxay579 closed 1 year ago

rxay579 commented 1 year ago

I think there may be an incompatibility introduced in Mythic Metals v1.18.0 for MC 1.19.4 with Roughly Enough Resources v2.8.0. When logging into a single player world, the loading gets to 100%, then goes to "Connection Lost" "Invalid player data". Screen snippet attached. Single-Player

I'm not seeing the issue with Mythic Metals v1.17.6 on the same mod setup. Have only been testing in a single player world so far. Logs attached for the same instance launching and logging in with MM v1.17.6, v1.18.0, v1.18.1, and v1.18.1 with RER disabled. MC name and UUID edited. mm-1.17.6.txt mm-1.18.0.txt mm-1.18.1.txt mm-1.18.1 - no RER.txt

Noaaan commented 1 year ago

I believe this issue was identified in https://github.com/fzzyhmstrs/EMI_loot/issues/26, and has already been fixed as of https://github.com/Noaaan/MythicMetals/commit/23e0f748518a697871fa1e1e4a5ac1e9ea81319b. It is scheduled for next release

rxay579 commented 1 year ago

Thanks, I'll re-test next update.

rxay579 commented 1 year ago

Was able to test with MC v1.20.1, MM v1.8.2, MM Deco v0.5.5, REI v12.0.634, and all their requirements in single player. The world appeared to create and load as normal. No extended testing yet.

Any chance MM v1.8.2 can still compile for MC v1.19.4 so the MM 1.8.x improvements can be used there? Understandable if you've moved on to MC v1.20.x.

Noaaan commented 1 year ago

I am planning on backporting the bugfixes to 1.19.4 sometime, just haven't gotten around to it yet.